Issue 29416567: Noissue - Added -fno-rtti flag, reduces build size by 5%

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29416567: Noissue - Added -fno-rtti flag, reduces build size by 5% (Closed)

Created:
April 18, 2017, 10:25 a.m. by Wladimir Palant

Modified:
April 18, 2017, 10:47 a.m.

Reviewers:
sergei

CC:
hub, Felix Dahlke

Base URL:
https://hg.adblockplus.org/adblockpluscore

Visibility:
Public.

Description

This is another FYI review, I do not really expect a controversy here. I have been able to track down some unnecessary libcxxabi dependencies to RTTI. After adding -fno-rtti flag the code size went down by 8 kB or almost 5%, due to some unnecesary exports and global type info removed here.

Patch Set 1 #

Created: April 18, 2017, 10:25 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	compile	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages