Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29416570: Noissue - [emscripten] Report memory layout correctly (Closed)

Created:
April 18, 2017, 12:21 p.m. by Wladimir Palant
Modified:
April 18, 2017, 12:58 p.m.
Reviewers:
sergei
CC:
hub, Felix Dahlke
Base URL:
https://hg.adblockplus.org/adblockpluscore
Visibility:
Public.

Description

getMemoryLayout() function is exported for debugging purposes. The update to Emscripten 1.37.3 broke it, the DYNAMICTOP value is now being stored in the C++ memory rather than JS. Yet this is the most important value here since it indicates the amount of allocated memory.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M compiled/shell.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Wladimir Palant
April 18, 2017, 12:21 p.m. (2017-04-18 12:21:49 UTC) #1
sergei
April 18, 2017, 12:49 p.m. (2017-04-18 12:49:51 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld