Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(412)

Issue 29416573: Issue 5153 - Simplify patterns.ini parsing (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 10 months ago by Wladimir Palant
Modified:
2 years, 10 months ago
Reviewers:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

This change applies on top of https://codereview.adblockplus.org/29408742/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -143 lines) Patch
M lib/filterStorage.js View 8 chunks +26 lines, -66 lines 0 comments Download
M test/data/patterns.ini View 1 chunk +1 line, -1 line 0 comments Download
M test/filterStorage.js View 3 chunks +11 lines, -11 lines 0 comments Download
M test/filterStorage_readwrite.js View 1 chunk +0 lines, -65 lines 0 comments Download

Messages

Total messages: 2
Wladimir Palant
2 years, 10 months ago (2017-04-18 13:33:44 UTC) #1
kzar
2 years, 10 months ago (2017-04-20 07:08:51 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5