Issue 5034 - Part 1: Pass a JsValue directly to SetProperty() and return from GetProperty()

src/GlobalJsObject.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 50 matching lines @@
       return v8::ThrowException(Utils::ToV8String(isolate,
       "_triggerEvent expects at least one parameter"));
     }
     std::string eventName = converted.front()->AsString();
     converted.erase(converted.begin());
     jsEngine->TriggerEvent(eventName, converted);
     return v8::Undefined();
   }
 }
 
-JsValuePtr GlobalJsObject::Setup(JsEngine& jsEngine, const AppInfo& appInfo,
-    const JsValuePtr& obj)
+JsValue& GlobalJsObject::Setup(JsEngine& jsEngine, const AppInfo& appInfo,
+    JsValue& obj)
 {
-  obj->SetProperty("setTimeout", jsEngine.NewCallback(::SetTimeoutCallback));
-  obj->SetProperty("_triggerEvent", jsEngine.NewCallback(::TriggerEventCallback));
-  obj->SetProperty("_fileSystem",
-      FileSystemJsObject::Setup(jsEngine, jsEngine.NewObject()));
-  obj->SetProperty("_webRequest",
-      WebRequestJsObject::Setup(jsEngine, jsEngine.NewObject()));
-  obj->SetProperty("console",
-      ConsoleJsObject::Setup(jsEngine, jsEngine.NewObject()));
-  obj->SetProperty("_appInfo",
-      AppInfoJsObject::Setup(appInfo, jsEngine.NewObject()));
+  obj.SetProperty("setTimeout", *jsEngine.NewCallback(::SetTimeoutCallback));
+  obj.SetProperty("_triggerEvent", *jsEngine.NewCallback(::TriggerEventCallback));
+  obj.SetProperty("_fileSystem",
+      FileSystemJsObject::Setup(jsEngine, *jsEngine.NewObject()));
+  obj.SetProperty("_webRequest",
+      WebRequestJsObject::Setup(jsEngine, *jsEngine.NewObject()));
+  obj.SetProperty("console",
+      ConsoleJsObject::Setup(jsEngine, *jsEngine.NewObject()));
+  obj.SetProperty("_appInfo",
+      AppInfoJsObject::Setup(appInfo, *jsEngine.NewObject()));
   return obj;
 }