Issue 29416579: Issue 5034 - Part 1: Pass a JsValue directly to SetProperty() and return from GetProperty()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29416579: Issue 5034 - Part 1: Pass a JsValue directly to SetProperty() and return from GetProperty() (Closed)

Created:
April 18, 2017, 9:17 p.m. by hub

Modified:
April 19, 2017, 3:18 p.m.

Reviewers:
sergei

Base URL:
https://hg.adblockplus.org/libadblockplus/

Visibility:
Public.

Description

Issue 5034 - Part 1: Pass a JsValue directly to SetProperty() and return from GetProperty()

Patch Set 2 : Remove JsValue test #

Created: April 19, 2017, 2:46 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -121 lines)			Patch
M	include/AdblockPlus/JsEngine.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	include/AdblockPlus/JsValue.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	shell/src/FiltersCommand.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	shell/src/MatchesCommand.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	shell/src/SubscriptionsCommand.cpp	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/AppInfoJsObject.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/AppInfoJsObject.cpp	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	src/ConsoleJsObject.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ConsoleJsObject.cpp	View		1 chunk	+8 lines, -8 lines	0 comments	Download
M	src/FileSystemJsObject.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/FileSystemJsObject.cpp	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	src/FilterEngine.cpp	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/GlobalJsObject.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/GlobalJsObject.cpp	View		1 chunk	+12 lines, -12 lines	0 comments	Download
M	src/JsEngine.cpp	View	1	2 chunks	+6 lines, -7 lines	0 comments	Download
M	src/JsValue.cpp	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/Notification.cpp	View		1 chunk	+11 lines, -11 lines	0 comments	Download
M	src/WebRequestJsObject.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/WebRequestJsObject.cpp	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	test/FilterEngine.cpp	View		6 chunks	+31 lines, -31 lines	0 comments	Download
M	test/JsEngine.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/JsValue.cpp	View		3 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

sergei

https://codereview.adblockplus.org/29416579/diff/29416580/src/JsEngine.cpp File src/JsEngine.cpp (right): https://codereview.adblockplus.org/29416579/diff/29416580/src/JsEngine.cpp#newcode333 src/JsEngine.cpp:333: if (global.IsUndefined() || global.IsNull()) It's different, previously it was ...

April 19, 2017, 10:24 a.m. (2017-04-19 10:24:31 UTC) #2

hub

updated patch. https://codereview.adblockplus.org/29416579/diff/29416580/src/JsEngine.cpp File src/JsEngine.cpp (right): https://codereview.adblockplus.org/29416579/diff/29416580/src/JsEngine.cpp#newcode333 src/JsEngine.cpp:333: if (global.IsUndefined() || global.IsNull()) On 2017/04/19 10:24:31, ...

April 19, 2017, 2:47 p.m. (2017-04-19 14:47:11 UTC) #3

LGTM

Expand All Messages | Collapse All Messages