Issue 5034 - Part 1: Pass a JsValue directly to SetProperty() and return from GetProperty()

src/Notification.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 46 matching lines @@
   }
 }
 
 Notification::Notification(JsValue&& jsValue)
   : JsValue(std::move(jsValue))
 {
 }
 
 NotificationType Notification::GetType() const
 {
-  return StringToNotificationType(GetProperty("type")->AsString());
+  return StringToNotificationType(GetProperty("type").AsString());
 }
 
 NotificationTexts Notification::GetTexts() const
 {
   JsValue jsTexts = jsEngine->Evaluate("API.getNotificationTexts")->Call(*this);
   NotificationTexts notificationTexts;
-  JsValuePtr jsTitle = jsTexts.GetProperty("title");
-  if (jsTitle->IsString())
+  JsValue jsTitle = jsTexts.GetProperty("title");
+  if (jsTitle.IsString())
   {
-    notificationTexts.title = jsTitle->AsString();
+    notificationTexts.title = jsTitle.AsString();
   }
-  JsValuePtr jsMessage = jsTexts.GetProperty("message");
-  if (jsMessage->IsString())
+  JsValue jsMessage = jsTexts.GetProperty("message");
+  if (jsMessage.IsString())
   {
-    notificationTexts.message = jsMessage->AsString();
+    notificationTexts.message = jsMessage.AsString();
   }
   return notificationTexts;
 }
 
 std::vector<std::string> Notification::GetLinks() const
 {
   std::vector<std::string> retValue;
-  JsValuePtr jsLinks = GetProperty("links");
-  if (!jsLinks->IsArray())
+  JsValue jsLinks = GetProperty("links");
+  if (!jsLinks.IsArray())
   {
     return retValue;
   }
-  JsValueList urlLinksList = jsLinks->AsList();
+  JsValueList urlLinksList = jsLinks.AsList();
   for (const auto& link : urlLinksList)
   {
     retValue.push_back(link->AsString());
   }
   return retValue;
 }
 
 void Notification::MarkAsShown()
 {
-  jsEngine->Evaluate("API.markNotificationAsShown")->Call(*GetProperty("id"));
+  jsEngine->Evaluate("API.markNotificationAsShown")->Call(GetProperty("id"));
 }