Issue 5034 - Part 1: Pass a JsValue directly to SetProperty() and return from GetProperty()

src/JsEngine.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 312 matching lines @@
     throw std::runtime_error("LogSystem cannot be null");
 
   logSystem = val;
 }
 
 
 void AdblockPlus::JsEngine::SetGlobalProperty(const std::string& name,
                                               const AdblockPlus::JsValue& value)
 {
   auto global = GetGlobalObject();
-  if (global.IsUndefined() || global.IsNull())

[sergei, 2017/04/19 10:24:31]

It's different, previously it was possible to set either undefined or null but
now it's not possible. I would rather remove this check completely in the new
code. 

[hub, 2017/04/19 14:47:11]

Done.

-    throw std::runtime_error("Global object cannot be null");
   global.SetProperty(name, value);
 }