src/FileSystemJsObject.cpp - Issue 29416579: Issue 5034 - Part 1: Pass a JsValue directly to SetProperty() and return from GetProperty()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/FileSystemJsObject.cpp

Issue 29416579: Issue 5034 - Part 1: Pass a JsValue directly to SetProperty() and return from GetProperty() (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/

Patch Set: Created April 18, 2017, 9:17 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/FileSystemJsObject.cpp

===================================================================

--- a/src/FileSystemJsObject.cpp

+++ b/src/FileSystemJsObject.cpp

@@ -344,18 +344,18 @@

std::string resolved = jsEngine->GetFileSystem()->Resolve(converted[0]->AsString());

return Utils::ToV8String(isolate, resolved);

}

-JsValuePtr FileSystemJsObject::Setup(JsEngine& jsEngine, const JsValuePtr& obj)

+JsValue& FileSystemJsObject::Setup(JsEngine& jsEngine, JsValue& obj)

{

- obj->SetProperty("read", jsEngine.NewCallback(::ReadCallback));

- obj->SetProperty("write", jsEngine.NewCallback(::WriteCallback));

- obj->SetProperty("move", jsEngine.NewCallback(::MoveCallback));

- obj->SetProperty("remove", jsEngine.NewCallback(::RemoveCallback));

- obj->SetProperty("stat", jsEngine.NewCallback(::StatCallback));

- obj->SetProperty("resolve", jsEngine.NewCallback(::ResolveCallback));

+ obj.SetProperty("read", *jsEngine.NewCallback(::ReadCallback));

+ obj.SetProperty("write", *jsEngine.NewCallback(::WriteCallback));

+ obj.SetProperty("move", *jsEngine.NewCallback(::MoveCallback));

+ obj.SetProperty("remove", *jsEngine.NewCallback(::RemoveCallback));

+ obj.SetProperty("stat", *jsEngine.NewCallback(::StatCallback));

+ obj.SetProperty("resolve", *jsEngine.NewCallback(::ResolveCallback));

return obj;

}

« no previous file with comments | « src/FileSystemJsObject.h ('k') | src/FilterEngine.cpp » ('j') | src/JsEngine.cpp » ('J')