Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/JsEngine.h

Issue 29416579: Issue 5034 - Part 1: Pass a JsValue directly to SetProperty() and return from GetProperty() (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Remove JsValue test Created April 19, 2017, 2:46 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/AdblockPlus/JsValue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/AdblockPlus/JsEngine.h
===================================================================
--- a/include/AdblockPlus/JsEngine.h
+++ b/include/AdblockPlus/JsEngine.h
@@ -272,17 +272,17 @@
*/
void SetLogSystem(const LogSystemPtr& val);
/**
* Sets a global property that can be accessed by all the scripts.
* @param name Name of the property to set.
* @param value Value of the property to set.
*/
- void SetGlobalProperty(const std::string& name, const AdblockPlus::JsValuePtr& value);
+ void SetGlobalProperty(const std::string& name, const AdblockPlus::JsValue& value);
/**
* Returns a pointer to associated v8::Isolate.
*/
v8::Isolate* GetIsolate()
{
return isolate->Get();
}
@@ -293,17 +293,17 @@
~TimerTask();
std::vector<std::unique_ptr<v8::Persistent<v8::Value>>> arguments;
};
typedef std::list<TimerTask> TimerTasks;
void CallTimerTask(const TimerTasks::const_iterator& timerTaskIterator);
explicit JsEngine(const ScopedV8IsolatePtr& isolate, TimerPtr timer);
- JsValuePtr GetGlobalObject();
+ JsValue GetGlobalObject();
/// Isolate must be disposed only after disposing of all objects which are
/// using it.
ScopedV8IsolatePtr isolate;
FileSystemPtr fileSystem;
WebRequestPtr webRequest;
LogSystemPtr logSystem;
« no previous file with comments | « no previous file | include/AdblockPlus/JsValue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld