src/AppInfoJsObject.cpp - Issue 29416579: Issue 5034 - Part 1: Pass a JsValue directly to SetProperty() and return from GetProperty()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/AppInfoJsObject.cpp

Issue 29416579: Issue 5034 - Part 1: Pass a JsValue directly to SetProperty() and return from GetProperty() (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/

Patch Set: Remove JsValue test Created April 19, 2017, 2:46 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/AppInfoJsObject.cpp

===================================================================

--- a/src/AppInfoJsObject.cpp

+++ b/src/AppInfoJsObject.cpp

@@ -18,18 +18,18 @@

#include <AdblockPlus/AppInfo.h>

#include <AdblockPlus/JsValue.h>

#include "AppInfoJsObject.h"

#include "Utils.h"

using namespace AdblockPlus;

-JsValuePtr AppInfoJsObject::Setup(const AppInfo& appInfo, const JsValuePtr& obj)

+JsValue& AppInfoJsObject::Setup(const AppInfo& appInfo, JsValue& obj)

{

- obj->SetProperty("version", appInfo.version);

- obj->SetProperty("name", appInfo.name);

- obj->SetProperty("application", appInfo.application);

- obj->SetProperty("applicationVersion", appInfo.applicationVersion);

- obj->SetProperty("locale", appInfo.locale);

- obj->SetProperty("developmentBuild", appInfo.developmentBuild);

+ obj.SetProperty("version", appInfo.version);

+ obj.SetProperty("name", appInfo.name);

+ obj.SetProperty("application", appInfo.application);

+ obj.SetProperty("applicationVersion", appInfo.applicationVersion);

+ obj.SetProperty("locale", appInfo.locale);

+ obj.SetProperty("developmentBuild", appInfo.developmentBuild);

return obj;

}

« no previous file with comments | « src/AppInfoJsObject.h ('k') | src/ConsoleJsObject.h » ('j') | no next file with comments »