Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/popupBlocker.js

Issue 29417555: Issue 5130 - Changes url protocol permissions to all urls (Closed)
Left Patch Set: change to explicit urls at handler registration Created April 19, 2017, 12:04 p.m.
Right Patch Set: fix redundancies introduced in last patch Created April 19, 2017, 12:21 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « lib/devtools.js ('k') | metadata.chrome » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 forgetPopup(details.tabId); 93 forgetPopup(details.tabId);
94 } 94 }
95 95
96 chrome.webNavigation.onCreatedNavigationTarget.addListener(details => 96 chrome.webNavigation.onCreatedNavigationTarget.addListener(details =>
97 { 97 {
98 if (!hasLoadingPopups()) 98 if (!hasLoadingPopups())
99 { 99 {
100 chrome.webRequest.onBeforeRequest.addListener( 100 chrome.webRequest.onBeforeRequest.addListener(
101 onPopupURLChanged, 101 onPopupURLChanged,
102 { 102 {
103 urls: ["http://*/*", "https://*/*", "ws://*/*", "wss://*/*"], 103 urls: ["http://*/*", "https://*/*"],
Sebastian Noack 2017/04/19 12:10:11 Same here.
Jon Sonesen 2017/04/19 12:22:27 Done.
104 types: ["main_frame"] 104 types: ["main_frame"]
105 } 105 }
106 ); 106 );
107 chrome.webNavigation.onCommitted.addListener(onPopupURLChanged); 107 chrome.webNavigation.onCommitted.addListener(onPopupURLChanged);
108 chrome.webNavigation.onCompleted.addListener(onCompleted); 108 chrome.webNavigation.onCompleted.addListener(onCompleted);
109 chrome.tabs.onRemoved.addListener(forgetPopup); 109 chrome.tabs.onRemoved.addListener(forgetPopup);
110 } 110 }
111 111
112 let {tabId} = details; 112 let {tabId} = details;
113 let popup = loadingPopups[tabId] = { 113 let popup = loadingPopups[tabId] = {
114 url: details.url, 114 url: details.url,
115 sourcePage: new ext.Page({id: details.sourceTabId}), 115 sourcePage: new ext.Page({id: details.sourceTabId}),
116 sourceFrame: null 116 sourceFrame: null
117 }; 117 };
118 let frame = ext.getFrame(details.sourceTabId, details.sourceFrameId); 118 let frame = ext.getFrame(details.sourceTabId, details.sourceFrameId);
119 119
120 if (checkWhitelisted(popup.sourcePage, frame)) 120 if (checkWhitelisted(popup.sourcePage, frame))
121 { 121 {
122 forgetPopup(tabId); 122 forgetPopup(tabId);
123 } 123 }
124 else 124 else
125 { 125 {
126 popup.sourceFrame = frame; 126 popup.sourceFrame = frame;
127 checkPotentialPopup(tabId, popup); 127 checkPotentialPopup(tabId, popup);
128 } 128 }
129 }); 129 });
LEFTRIGHT

Powered by Google App Engine
This is Rietveld