Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29417555: Issue 5130 - Changes url protocol permissions to all urls (Closed)

Created:
April 19, 2017, 9:29 a.m. by Jon Sonesen
Modified:
April 24, 2017, 7:13 a.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 5130 - Changes url protocol permissions to all urls

Patch Set 1 #

Patch Set 2 : change to explicit urls at handler registration #

Total comments: 4

Patch Set 3 : fix redundancies introduced in last patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M ext/background.js View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/devtools.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lib/popupBlocker.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M metadata.chrome View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6
Jon Sonesen
April 19, 2017, 9:29 a.m. (2017-04-19 09:29:48 UTC) #1
Sebastian Noack
Perhaps we should use an explicit URL pattern when registering the webRequest handlers now, since ...
April 19, 2017, 9:39 a.m. (2017-04-19 09:39:49 UTC) #2
Jon Sonesen
On 2017/04/19 09:39:49, Sebastian Noack wrote: > Perhaps we should use an explicit URL pattern ...
April 19, 2017, 9:53 a.m. (2017-04-19 09:53:49 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29417555/diff/29417558/lib/devtools.js File lib/devtools.js (right): https://codereview.adblockplus.org/29417555/diff/29417558/lib/devtools.js#newcode349 lib/devtools.js:349: urls: ["http://*/*", "https://*/*", "ws://*/*", "wss://*/*"], ws[s]:// is redundant here ...
April 19, 2017, 12:10 p.m. (2017-04-19 12:10:11 UTC) #4
Jon Sonesen
https://codereview.adblockplus.org/29417555/diff/29417558/lib/devtools.js File lib/devtools.js (right): https://codereview.adblockplus.org/29417555/diff/29417558/lib/devtools.js#newcode349 lib/devtools.js:349: urls: ["http://*/*", "https://*/*", "ws://*/*", "wss://*/*"], On 2017/04/19 12:10:11, Sebastian ...
April 19, 2017, 12:22 p.m. (2017-04-19 12:22:28 UTC) #5
Sebastian Noack
April 19, 2017, 12:31 p.m. (2017-04-19 12:31:53 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld