Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/devtools.js

Issue 29417555: Issue 5130 - Changes url protocol permissions to all urls (Closed)
Patch Set: change to explicit urls at handler registration Created April 19, 2017, 12:04 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ext/background.js ('k') | lib/popupBlocker.js » ('j') | lib/popupBlocker.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/devtools.js
===================================================================
--- a/lib/devtools.js
+++ b/lib/devtools.js
@@ -341,17 +341,17 @@
return;
let inspectedTabId = parseInt(match[1], 10);
let localOnBeforeRequest = onBeforeRequest.bind();
chrome.webRequest.onBeforeRequest.addListener(
localOnBeforeRequest,
{
- urls: ["<all_urls>"],
+ urls: ["http://*/*", "https://*/*", "ws://*/*", "wss://*/*"],
Sebastian Noack 2017/04/19 12:10:11 ws[s]:// is redundant here since this code is only
Jon Sonesen 2017/04/19 12:22:27 Done.
types: ["main_frame"],
tabId: inspectedTabId
}
);
if (!hasPanels())
{
ext.pages.onLoading.addListener(onLoading);
« no previous file with comments | « ext/background.js ('k') | lib/popupBlocker.js » ('j') | lib/popupBlocker.js » ('J')

Powered by Google App Engine
This is Rietveld