Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/popupBlocker.js

Issue 29417555: Issue 5130 - Changes url protocol permissions to all urls (Closed)
Patch Set: fix redundancies introduced in last patch Created April 19, 2017, 12:21 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/devtools.js ('k') | metadata.chrome » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/popupBlocker.js
===================================================================
--- a/lib/popupBlocker.js
+++ b/lib/popupBlocker.js
@@ -95,17 +95,17 @@
chrome.webNavigation.onCreatedNavigationTarget.addListener(details =>
{
if (!hasLoadingPopups())
{
chrome.webRequest.onBeforeRequest.addListener(
onPopupURLChanged,
{
- urls: ["<all_urls>"],
+ urls: ["http://*/*", "https://*/*"],
types: ["main_frame"]
}
);
chrome.webNavigation.onCommitted.addListener(onPopupURLChanged);
chrome.webNavigation.onCompleted.addListener(onCompleted);
chrome.tabs.onRemoved.addListener(forgetPopup);
}
« no previous file with comments | « lib/devtools.js ('k') | metadata.chrome » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld