Issue 29417624: Issue 5034 - Part 4: JsEngine::Evaluate() return a JsValue

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29417624: Issue 5034 - Part 4: JsEngine::Evaluate() return a JsValue (Closed)

Created:
April 19, 2017, 6:18 p.m. by hub

Modified:
April 20, 2017, 1:31 p.m.

Reviewers:
sergei

Base URL:
https://hg.adblockplus.org/libadblockplus/

Visibility:
Public.

Description

Issue 5034 - Part 4: JsEngine::Evaluate() return a JsValue

Patch Set 2 : Rebased on top of part 3 #

Patch Set 3 : Rebased again #

Created: April 20, 2017, 1:02 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+282 lines, -273 lines)			Patch
M	include/AdblockPlus/JsEngine.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	include/AdblockPlus/JsValue.h	View		2 chunks	+9 lines, -8 lines	0 comments	Download
M	src/FilterEngine.cpp	View		5 chunks	+45 lines, -45 lines	0 comments	Download
M	src/JsEngine.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/JsValue.cpp	View		1 chunk	+12 lines, -4 lines	0 comments	Download
M	src/Notification.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/AppInfoJsObject.cpp	View		1 chunk	+12 lines, -12 lines	0 comments	Download
M	test/FileSystemJsObject.cpp	View		2 chunks	+14 lines, -14 lines	0 comments	Download
M	test/GlobalJsObject.cpp	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	test/JsEngine.cpp	View	1 2	3 chunks	+7 lines, -7 lines	0 comments	Download
M	test/JsValue.cpp	View		1 chunk	+142 lines, -142 lines	0 comments	Download
M	test/UpdateCheck.cpp	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	test/WebRequest.cpp	View		2 chunks	+27 lines, -27 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

sergei

LGTM https://codereview.adblockplus.org/29417624/diff/29417625/include/AdblockPlus/JsValue.h File include/AdblockPlus/JsValue.h (left): https://codereview.adblockplus.org/29417624/diff/29417625/include/AdblockPlus/JsValue.h#oldcode45 include/AdblockPlus/JsValue.h:45: typedef std::shared_ptr<JsValue> JsValuePtr; This is an achievement!

April 19, 2017, 7:11 p.m. (2017-04-19 19:11:16 UTC) #2

updated patch: had to rebase.

Expand All Messages | Collapse All Messages