Noissue - Create context in ~JsValue() before disposing value

Noissue - Create context in ~JsValue() before disposing value

[sergei, 2017-04-20 12:50:05]

LGTM, but I would like to explain it a bit in the commit message.

We need it because it can be a reason of data race and of race condition.
Instances of JsValue can being destroyed from different threads or an instance
of JsValue can being destroyed while some JS code is being executed and in both
such cases two threads will try to access and modify isolate at the same moment.

[hub, 2017-04-20 13:13:21]

On 2017/04/20 12:50:05, sergei wrote:
> LGTM, but I would like to explain it a bit in the commit message.
> 
> We need it because it can be a reason of data race and of race condition.
> Instances of JsValue can being destroyed from different threads or an instance
> of JsValue can being destroyed while some JS code is being executed and in
both
> such cases two threads will try to access and modify isolate at the same
moment.

Here is the full commit message now: 

"
Noissue - Create context in ~JsValue() before disposing value

This is needed to ensure there is no data race as JS code could
be running on a different thread.
"

Is this enough?

[sergei, 2017-04-20 13:16:55]

On 2017/04/20 13:13:21, hub wrote:
> On 2017/04/20 12:50:05, sergei wrote:
> > LGTM, but I would like to explain it a bit in the commit message.
> > 
> > We need it because it can be a reason of data race and of race condition.
> > Instances of JsValue can being destroyed from different threads or an
instance
> > of JsValue can being destroyed while some JS code is being executed and in
> both
> > such cases two threads will try to access and modify isolate at the same
> moment.
> 
> Here is the full commit message now: 
> 
> "
> Noissue - Create context in ~JsValue() before disposing value
> 
> This is needed to ensure there is no data race as JS code could
> be running on a different thread.
> "
> 
> Is this enough?

I would add where exactly the the race
Instances of JsValue can being destroyed from different threads or an instance
of JsValue can being destroyed while some JS code is being executed and in
both such cases two threads will try to access and modify isolate at the same
moment.

BTW, don't forget about review URL.