Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29418653: Noissue - Do not make a copy of _listeners while dispatching (Closed)

Created:
April 20, 2017, 5:43 p.m. by Manish Jethani
Modified:
April 20, 2017, 6:27 p.m.
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Noissue - Do not make a copy of _listeners while dispatching

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ext/common.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3
Manish Jethani
April 20, 2017, 5:43 p.m. (2017-04-20 17:43:48 UTC) #1
Sebastian Noack
LGTM. But please add a link to the discussion in the other review here, for ...
April 20, 2017, 5:45 p.m. (2017-04-20 17:45:22 UTC) #2
Manish Jethani
April 20, 2017, 5:46 p.m. (2017-04-20 17:46:59 UTC) #3
As discussed in issue #29410614 here, there's no need to make a copy of the
_listeners object since it is a set now.

https://codereview.adblockplus.org/29410614/#msg10

Powered by Google App Engine
This is Rietveld