Unified Diff: include/AdblockPlus/Notification.h
Issue 29419629:
Issue 5164 - Remove NotificationPtr (Closed)
Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set:
Created April 21, 2017, 2:08 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« include/AdblockPlus/FilterEngine.h ('k')
|
src/FilterEngine.cpp » ('j')
|
test/Notification.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: include/AdblockPlus/Notification.h |
| =================================================================== |
| --- a/include/AdblockPlus/Notification.h |
| +++ b/include/AdblockPlus/Notification.h |
| @@ -47,23 +47,23 @@ |
| /** |
| * Wrapper for an Adblock Plus notification object. |
| */ |
| class Notification: public JsValue, |
| public std::enable_shared_from_this<Notification> |
| { |
| friend class FilterEngine; |
| - protected: |
| + public: |
| /** |
| * Constructor. |
| * @param jsValue `JsValue&&` notification JavaScript object. |
| */ |
| explicit Notification(JsValue&& jsValue); |
|
sergei
2017/04/21 15:30:33
I don't think it's a good idea to make this constr
hub
2017/04/21 16:29:31
It was for the tests. I'll find a way.
|
| - public: |
| + |
| /** |
| * Retrieves the type of this notification. |
| * @return Type of this notification. |
| */ |
| NotificationType GetType() const; |
| /** |
| * Retrieves the title and message of this notification. |
| @@ -79,12 +79,11 @@ |
| /** |
| * Marks this notification as shown. It is only relevant for question |
| * notifications. Other notifications are marked automatically. |
| */ |
| void MarkAsShown(); |
| private: |
| }; |
| - typedef std::shared_ptr<Notification> NotificationPtr; |
| } |
| #endif |
« no previous file with comments
|
« include/AdblockPlus/FilterEngine.h ('k')
|
src/FilterEngine.cpp » ('j')
|
test/Notification.cpp » ('J')
