Unified Diff: include/AdblockPlus/FilterEngine.h
Issue 29420561:
Noissue - don't inherit JsValue derived from std::enable_shared_from_this (Closed)
Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set:
Created April 24, 2017, 8:26 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
include/AdblockPlus/Notification.h » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: include/AdblockPlus/FilterEngine.h |
| diff --git a/include/AdblockPlus/FilterEngine.h b/include/AdblockPlus/FilterEngine.h |
| index be5b44f68dfafdfb9f30ba644888e616fc671d20..fe9cc42306f58ab9ad766b8d07f4a37fab71112f 100644 |
| --- a/include/AdblockPlus/FilterEngine.h |
| +++ b/include/AdblockPlus/FilterEngine.h |
| @@ -37,8 +37,7 @@ namespace AdblockPlus |
| * [filter properties](https://adblockplus.org/jsdoc/adblockpluscore/Filter.html), |
| * use `GetProperty()` to retrieve them by name. |
| */ |
| - class Filter : public JsValue, |
| - public std::enable_shared_from_this<Filter> |
| + class Filter : public JsValue |
| { |
| public: |
| /** |
| @@ -87,8 +86,7 @@ namespace AdblockPlus |
| * [subscription properties](https://adblockplus.org/jsdoc/adblockpluscore/Subscription.html), |
| * use `GetProperty()` to retrieve them by name. |
| */ |
| - class Subscription : public JsValue, |
| - public std::enable_shared_from_this<Subscription> |
| + class Subscription : public JsValue |
| { |
| public: |
| /** |
« no previous file with comments
|
« no previous file
|
include/AdblockPlus/Notification.h » ('j')
|
no next file with comments »
