include/AdblockPlus/Notification.h - Issue 29420561: Noissue - don't inherit JsValue derived from std::enable_shared_from_this

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: include/AdblockPlus/Notification.h

Issue 29420561: Noissue - don't inherit JsValue derived from std::enable_shared_from_this (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git

Patch Set: Created April 24, 2017, 8:26 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/AdblockPlus/Notification.h

diff --git a/include/AdblockPlus/Notification.h b/include/AdblockPlus/Notification.h

index de5053f2f02a7a4c8b81c6f7d46b1ac8f7481bf4..e8e3a68dd80c5eb6bd15a973be869253d6ed942e 100644

--- a/include/AdblockPlus/Notification.h

+++ b/include/AdblockPlus/Notification.h

@@ -48,8 +48,7 @@ namespace AdblockPlus

/**

* Wrapper for an Adblock Plus notification object.

- class Notification: public JsValue,

- public std::enable_shared_from_this<Notification>

+ class Notification: public JsValue

{

friend class FilterEngine;

protected:

« no previous file with comments | « include/AdblockPlus/FilterEngine.h ('k') | no next file » | no next file with comments »