Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29420569: Issue 5170 - Force usage of Android version code v0 function (Closed)

Created:
April 24, 2017, 9:55 a.m. by diegocarloslima
Modified:
April 24, 2017, 11:15 a.m.
Reviewers:
anton, Felix Dahlke
CC:
René Jeschke
Visibility:
Public.

Description

Issue 5170 - Force usage of Android version code v0 function

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M python/mozbuild/mozbuild/android_version_code.py View 1 chunk +3 lines, -1 line 1 comment Download

Messages

Total messages: 4
diegocarloslima
April 24, 2017, 9:56 a.m. (2017-04-24 09:56:16 UTC) #1
anton
On 2017/04/24 09:56:16, diegocarloslima wrote: LGTM
April 24, 2017, 9:57 a.m. (2017-04-24 09:57:51 UTC) #2
anton
https://codereview.adblockplus.org/29420569/diff/29420570/python/mozbuild/mozbuild/android_version_code.py File python/mozbuild/mozbuild/android_version_code.py (right): https://codereview.adblockplus.org/29420569/diff/29420570/python/mozbuild/mozbuild/android_version_code.py#newcode135 python/mozbuild/mozbuild/android_version_code.py:135: return android_version_code_v1(buildid, *args, **kwargs) minor Q: why not just ...
April 24, 2017, 9:59 a.m. (2017-04-24 09:59:02 UTC) #3
Felix Dahlke
April 24, 2017, 10:19 a.m. (2017-04-24 10:19:58 UTC) #4
LGTM as a quick fix - but I couldn't understand at first glance what the v1
function is for, and why it results in a 2015* timestamp. I feel we should keep
the issue open and look for alternative fixes.

Powered by Google App Engine
This is Rietveld