Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29420584: Noissue - Modify Math object for unit tests in a more sane way (Closed)

Created:
April 24, 2017, 1:27 p.m. by Wladimir Palant
Modified:
April 25, 2017, 12:40 p.m.
Reviewers:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Noissue - Modify Math object for unit tests in a more sane way The current approach was breaking Emscripten code that relies on Math.ceil

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M test/_common.js View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 2
Wladimir Palant
April 24, 2017, 1:28 p.m. (2017-04-24 13:28:01 UTC) #1
kzar
April 25, 2017, 10 a.m. (2017-04-25 10:00:58 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld