Issue 5185 - [emscripten] More compact definition of class prototypes

compiled/bindings/generator.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 188 matching lines @@
   void register_property(TYPEID classID, const char* name,
       const FunctionInfo& getter, const FunctionInfo& setter,
       const char* jsValue = "");
 
   void register_method(TYPEID classID, const char* name,
       const FunctionInfo& call);
 
   void register_differentiator(TYPEID classID, size_t offset,
       std::vector<std::pair<int, std::string>>& mapping);
 
-  const std::string generateCall(const FunctionInfo& call,
+  std::string generateCall(const FunctionInfo& call,
       std::vector<std::string>& params);
 
-  const std::string wrapCall(const FunctionInfo& call, bool isFunction = true);

[hub, 2017/04/25 18:24:58]

since we return a copy, do we really need the "const" here? 

[Wladimir Palant, 2017/04/26 05:52:55]

The "const" modifier in C++ is really weird. Hey, I am still learning :)

Yes, you are right of course. Fixed, and also removed
generatePropertyDescriptor() below.

-
-  std::string generatePropertyDescriptor(const PropertyInfo& property);
+  std::string wrapCall(const FunctionInfo& call, bool isFunction = true);
 
   void printHelpers();
 
   void printClass(const ClassInfo& cls);
 }
 
 template<typename ClassType,
     typename BaseClass = bindings_internal::NoBaseClass,
     typename std::enable_if<std::is_base_of<ref_counted, ClassType>::value>::type* = nullptr>
 class class_
@@ skipping 68 matching lines @@
     for (const auto& item : list)
       mapping.emplace_back(item.first, item.second);
 
     bindings_internal::register_differentiator(
         bindings_internal::TypeInfo<ClassType>(), offset, mapping);
     return *this;
   }
 };
 
 void printBindings();