Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29421701: Issue 5185 - [emscripten] More compact definition of class prototypes (Closed)

Created:
April 25, 2017, 2:13 p.m. by Wladimir Palant
Modified:
April 27, 2017, 12:14 p.m.
Reviewers:
sergei, hub
CC:
Felix Dahlke
Base URL:
https://hg.adblockplus.org/adblockpluscore
Visibility:
Public.

Description

While the performance impact of this change is negligible (it might save us a few milliseconds of startup time), it currently saves around 2.5 kB / 1.5% in build size.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed bogus const modifiers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -35 lines) Patch
M compiled/bindings/generator.h View 1 1 chunk +2 lines, -4 lines 0 comments Download
M compiled/bindings/generator.cpp View 1 5 chunks +47 lines, -31 lines 0 comments Download

Messages

Total messages: 5
Wladimir Palant
April 25, 2017, 2:13 p.m. (2017-04-25 14:13:05 UTC) #1
hub
https://codereview.adblockplus.org/29421701/diff/29421702/compiled/bindings/generator.h File compiled/bindings/generator.h (right): https://codereview.adblockplus.org/29421701/diff/29421702/compiled/bindings/generator.h#newcode212 compiled/bindings/generator.h:212: const std::string wrapCall(const FunctionInfo& call, bool isFunction = true); ...
April 25, 2017, 6:24 p.m. (2017-04-25 18:24:58 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29421701/diff/29421702/compiled/bindings/generator.h File compiled/bindings/generator.h (right): https://codereview.adblockplus.org/29421701/diff/29421702/compiled/bindings/generator.h#newcode212 compiled/bindings/generator.h:212: const std::string wrapCall(const FunctionInfo& call, bool isFunction = true); ...
April 26, 2017, 5:52 a.m. (2017-04-26 05:52:55 UTC) #3
hub
LGTM
April 26, 2017, 12:09 p.m. (2017-04-26 12:09:34 UTC) #4
sergei
April 26, 2017, 3:58 p.m. (2017-04-26 15:58:43 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld