Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29421715: Noissue - fix regression in tests (Closed)

Created:
April 25, 2017, 8:06 p.m. by sergei
Modified:
April 25, 2017, 8:20 p.m.
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

It turned out that moving happens before the choosing of the destination of the assignment (see affected code), thus we firstly move the value from `subscription` and then call `subscription.IsAA()` on the empty object. Review: https://codereview.adblockplus.org/29421715

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/FilterEngine.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
sergei
April 25, 2017, 8:08 p.m. (2017-04-25 20:08:33 UTC) #1
hub
On 2017/04/25 20:08:33, sergei wrote: LGTM good catch.
April 25, 2017, 8:13 p.m. (2017-04-25 20:13:51 UTC) #2
sergei
April 25, 2017, 8:20 p.m. (2017-04-25 20:20:47 UTC) #3
Message was sent while issue was closed.
> good catch.

We just need to run tests before pushing.

Powered by Google App Engine
This is Rietveld