Issue 5189 - use r-value references when objects should be transferred

include/AdblockPlus/FilterEngine.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 210 matching lines @@
      */
     typedef std::function<void(const std::string&)> UpdateCheckDoneCallback;
 
     /**
      * Callback type invoked when the filters change.
      * The first parameter is the action event code (see
      * [FilterNotifier.triggerListeners](https://adblockplus.org/jsdoc/adblockpluscore/FilterNotifier.html#.triggerListeners)
      * for the full list).
      * The second parameter is the filter/subscription object affected, if any.
      */
-    typedef std::function<void(const std::string&, const JsValue&)> FilterChangeCallback;
+    typedef std::function<void(const std::string&, JsValue&&)> FilterChangeCallback;
 
     /**
      * Container of name-value pairs representing a set of preferences.
      */
     typedef std::map<std::string, AdblockPlus::JsValue> Prefs;
 
     /**
      * Callback type invoked when a new notification should be shown.
      * The parameter is the Notification object to be shown.
      */
-    typedef std::function<void(Notification&)> ShowNotificationCallback;
+    typedef std::function<void(Notification&&)> ShowNotificationCallback;
 
     /**
      * Callback function returning false when current connection is not
      * allowedConnectionType, e.g. because it is a metered connection.
      */
     typedef std::function<bool(const std::string* allowedConnectionType)> IsConnectionAllowedCallback;
 
     /**
      * FilterEngine creation parameters.
      */
@@ skipping 296 matching lines @@
     JsEnginePtr jsEngine;
     bool firstRun;
     int updateCheckId;
     static const std::map<ContentType, std::string> contentTypes;
 
     explicit FilterEngine(const JsEnginePtr& jsEngine);
 
     FilterPtr CheckFilterMatch(const std::string& url,
                                ContentTypeMask contentTypeMask,
                                const std::string& documentUrl) const;
-    void UpdateAvailable(const UpdateAvailableCallback& callback, const JsValueList& params) const;
-    void UpdateCheckDone(const std::string& eventName,
-                         const UpdateCheckDoneCallback& callback, const JsValueList& params);
-    void FilterChanged(const FilterChangeCallback& callback, const JsValueList& params) const;
-    void ShowNotification(const ShowNotificationCallback& callback,
-      const JsValueList& param) const;
+    void FilterChanged(const FilterChangeCallback& callback, JsValueList&& params) const;
     FilterPtr GetWhitelistingFilter(const std::string& url,
       ContentTypeMask contentTypeMask, const std::string& documentUrl) const;
     FilterPtr GetWhitelistingFilter(const std::string& url,
       ContentTypeMask contentTypeMask,
       const std::vector<std::string>& documentUrls) const;
   };
 }
 
 #endif