Issue 29422625: Issue 5189 - use r-value references when objects should be transferred

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29422625: Issue 5189 - use r-value references when objects should be transferred (Closed)

Created:
April 26, 2017, 2:14 p.m. by sergei

Modified:
April 26, 2017, 3:22 p.m.

Reviewers:
hub

CC:
Felix Dahlke, anton

Base URL:
https://github.com/adblockplus/libadblockplus.git

Visibility:
Public.

Description

# I have also made changes even when it was not required to compile it, in particular compiler was able to convert a function accepting a const reference to a function accepting r-value reference. I made it for consistency and expect that it will simplify the maintenance of this code.

Patch Set 1 #

Created: April 26, 2017, 2:14 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -89 lines)			Patch
M	include/AdblockPlus/FilterEngine.h	View	3 chunks	+3 lines, -8 lines	0 comments	Download
M	include/AdblockPlus/JsEngine.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/FilterEngine.cpp	View	6 chunks	+28 lines, -47 lines	0 comments	Download
M	src/GlobalJsObject.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/JsEngine.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/FilterEngine.cpp	View	3 chunks	+5 lines, -16 lines	0 comments	Download
M	test/JsEngine.cpp	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	test/Notification.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/UpdateCheck.cpp	View	3 chunks	+7 lines, -8 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages