Issue 5189 - use r-value references when objects should be transferred

src/GlobalJsObject.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 45 matching lines @@
     AdblockPlus::JsEnginePtr jsEngine = AdblockPlus::JsEngine::FromArguments(arguments);
     AdblockPlus::JsValueList converted = jsEngine->ConvertArguments(arguments);
     if (converted.size() < 1)
     {
       v8::Isolate* isolate = arguments.GetIsolate();
       return v8::ThrowException(Utils::ToV8String(isolate,
       "_triggerEvent expects at least one parameter"));
     }
     std::string eventName = converted.front().AsString();
     converted.erase(converted.cbegin());
-    jsEngine->TriggerEvent(eventName, converted);
+    jsEngine->TriggerEvent(eventName, move(converted));
     return v8::Undefined();
   }
 }
 
 JsValue& GlobalJsObject::Setup(JsEngine& jsEngine, const AppInfo& appInfo,
     JsValue& obj)
 {
   obj.SetProperty("setTimeout", jsEngine.NewCallback(::SetTimeoutCallback));
   obj.SetProperty("_triggerEvent", jsEngine.NewCallback(::TriggerEventCallback));
   auto value = jsEngine.NewObject();
   obj.SetProperty("_fileSystem", FileSystemJsObject::Setup(jsEngine, value));
   value = jsEngine.NewObject();
   obj.SetProperty("_webRequest", WebRequestJsObject::Setup(jsEngine, value));
   value = jsEngine.NewObject();
   obj.SetProperty("console", ConsoleJsObject::Setup(jsEngine, value));
   value = jsEngine.NewObject();
   obj.SetProperty("_appInfo", AppInfoJsObject::Setup(appInfo, value));
   return obj;
 }