Issue 5189 - use r-value references when objects should be transferred

test/JsEngine.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <stdexcept>
 #include "BaseJsTest.h"
 
+using namespace AdblockPlus;
+
 namespace
 {
   class JsEngineTest : public BaseJsTest
   {
   };
 }
 
 TEST_F(JsEngineTest, Evaluate)
 {
   jsEngine->Evaluate("function hello() { return 'Hello'; }");
@@ skipping 89 matching lines @@
     ASSERT_EQ(0u, value2.GetOwnPropertyNames().size());
 
     ASSERT_TRUE(IsSame(*jsEngine, value, value2));
   }
 }
 
 TEST_F(JsEngineTest, EventCallbacks)
 {
   bool callbackCalled = false;
   AdblockPlus::JsValueList callbackParams;
-  auto Callback = [&callbackCalled, & callbackParams](
-    const AdblockPlus::JsValueList& params)
+  auto Callback = [&callbackCalled, &callbackParams](JsValueList&& params)
   {
     callbackCalled = true;
-    callbackParams = params;
+    callbackParams = move(params);
   };
 
   // Trigger event without a callback
   callbackCalled = false;
   jsEngine->Evaluate("_triggerEvent('foobar')");
   ASSERT_FALSE(callbackCalled);
 
   // Set callback
   jsEngine->SetEventCallback("foobar", Callback);
   callbackCalled = false;
@@ skipping 41 matching lines @@
 
 TEST(NewJsEngineTest, GlobalPropertyTest)
 {
   AdblockPlus::JsEnginePtr jsEngine(AdblockPlus::JsEngine::New());
   jsEngine->SetGlobalProperty("foo", jsEngine->NewValue("bar"));
   auto foo = jsEngine->Evaluate("foo");
   ASSERT_TRUE(foo.IsString());
   ASSERT_EQ(foo.AsString(), "bar");
 }