src/JsEngine.cpp - Issue 29422625: Issue 5189 - use r-value references when objects should be transferred

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/JsEngine.cpp

Issue 29422625: Issue 5189 - use r-value references when objects should be transferred (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git

Patch Set: Created April 26, 2017, 2:14 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/JsEngine.cpp

diff --git a/src/JsEngine.cpp b/src/JsEngine.cpp

index 3aaaeb9cd0924cc90503c6e869309e56ef3d2bf9..71be92f3735f5036adba4dbb03a64378ad98430f 100644

--- a/src/JsEngine.cpp

+++ b/src/JsEngine.cpp

@@ -187,7 +187,7 @@ void AdblockPlus::JsEngine::RemoveEventCallback(const std::string& eventName)

eventCallbacks.erase(eventName);

}

-void AdblockPlus::JsEngine::TriggerEvent(const std::string& eventName, const AdblockPlus::JsValueList& params)

+void AdblockPlus::JsEngine::TriggerEvent(const std::string& eventName, AdblockPlus::JsValueList&& params)

{

EventCallback callback;

{

@@ -197,7 +197,7 @@ void AdblockPlus::JsEngine::TriggerEvent(const std::string& eventName, const Adb

return;

callback = it->second;

}

- callback(params);

+ callback(move(params));

}

void AdblockPlus::JsEngine::Gc()

« no previous file with comments | « src/GlobalJsObject.cpp ('k') | test/FilterEngine.cpp » ('j') | no next file with comments »