Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(88)

Issue 29424653: Issue 4872 - Update Adblock Browser for iOS section of ABP privacy policy (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 6 months ago by juliandoucette
Modified:
2 years, 6 months ago
Reviewers:
tamara, saroyanm
CC:
Lisa, j.nink
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -13 lines) Patch
M pages/privacy.html View 1 chunk +35 lines, -13 lines 1 comment Download

Messages

Total messages: 4
juliandoucette
2 years, 6 months ago (2017-04-28 09:52:22 UTC) #1
saroyanm
Only one comment we can discuss other from that looks good. https://codereview.adblockplus.org/29424653/diff/29424654/pages/privacy.html File pages/privacy.html (right): ...
2 years, 6 months ago (2017-04-28 10:36:04 UTC) #2
tamara
On 2017/04/28 10:36:04, saroyanm wrote: > Only one comment we can discuss other from that ...
2 years, 6 months ago (2017-04-28 10:59:46 UTC) #3
saroyanm
2 years, 6 months ago (2017-04-28 11:32:21 UTC) #4
On 2017/04/28 10:59:46, tamara wrote:
> On 2017/04/28 10:36:04, saroyanm wrote:
> > Only one comment we can discuss other from that looks good.
> > 
> > https://codereview.adblockplus.org/29424653/diff/29424654/pages/privacy.html
> > File pages/privacy.html (right):
> > 
> >
>
https://codereview.adblockplus.org/29424653/diff/29424654/pages/privacy.html#...
> > pages/privacy.html:189: {{abb-ios-crash-item-1[list item] Bundle identifier,
> > bundle version and short bundle version string of <fix>Adblock Browser</fix>
> for
> > <fix>iOS</fix>. }}
> > Note: When updating the stringID the translations can be lost in crowdin,
this
> > changes rather small (punctuation and space), not sure if it worth to change
> the
> > stringID otherwise we need to inform Tamara about that.
> 
> I'm afraid the translations were already lost in Crowdin after we updated the
> whole page (hence why it's displayed only in French and German), so it really
> wouldn't make much difference, in my opinion. That string will still have to
be
> implemented for the second part of the text anyway, so just a bit more of work
> shouldn't be a problem.

Considering Tamara's comment LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5