Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29424656: Issue 5187 - Update text and link to AA application form on eyeo.com/services (Closed)

Created:
April 28, 2017, 10:02 a.m. by juliandoucette
Modified:
May 2, 2017, 5:28 p.m.
Reviewers:
saroyanm
CC:
Lisa
Base URL:
https://hg.adblockplus.org/web.eyeo.com
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Un-localized link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M includes/services/publisher.md View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
juliandoucette
April 28, 2017, 10:02 a.m. (2017-04-28 10:02:08 UTC) #1
saroyanm
LGTM: with a small nit. https://codereview.adblockplus.org/29424656/diff/29424657/includes/services/publisher.md File includes/services/publisher.md (right): https://codereview.adblockplus.org/29424656/diff/29424657/includes/services/publisher.md#newcode5 includes/services/publisher.md:5: Apply to get your ...
April 28, 2017, 10:52 a.m. (2017-04-28 10:52:29 UTC) #2
juliandoucette
https://codereview.adblockplus.org/29424656/diff/29424657/includes/services/publisher.md File includes/services/publisher.md (right): https://codereview.adblockplus.org/29424656/diff/29424657/includes/services/publisher.md#newcode5 includes/services/publisher.md:5: Apply to get your ads whitelisted by filling out ...
May 2, 2017, 8:48 a.m. (2017-05-02 08:48:03 UTC) #3
saroyanm
LGTM
May 2, 2017, 8:51 a.m. (2017-05-02 08:51:01 UTC) #4
juliandoucette
May 2, 2017, 5:28 p.m. (2017-05-02 17:28:36 UTC) #5
On 2017/05/02 08:51:01, saroyanm wrote:
> LGTM

https://hg.adblockplus.org/web.eyeo.com/rev/ebfcc818d658

Powered by Google App Engine
This is Rietveld