Issue 29424659: Noissue - generalize storing of `JsValue`s in `JsEngine`

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29424659: Noissue - generalize storing of `JsValue`s in `JsEngine` (Closed)

Created:
April 28, 2017, 10:27 a.m. by sergei

Modified:
April 28, 2017, 2:38 p.m.

Reviewers:
hub

CC:
Felix Dahlke

Base URL:
https://github.com/adblockplus/libadblockplus.git

Visibility:
Public.

Description

The beauty of it is that it allows to capture JsValue (actually ID of stored values) which is normally references JsEngine by a function stored in JsEngine as a callback and avoid a circular referencing. # this change is also required for https://issues.adblockplus.org/ticket/5182

Patch Set 1 #

Patch Set 2 : add empty line #

Created: April 28, 2017, 10:49 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -26 lines)			Patch
	M	include/AdblockPlus/JsEngine.h	View	1	5 chunks	+39 lines, -8 lines	0 comments	Download
	M	src/JsEngine.cpp	View		3 chunks	+50 lines, -18 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages