Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(716)

Issue 29424786: Issue 5182 - fix IsConnectionAllowed (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 2 weeks ago by sergei
Modified:
7 months, 2 weeks ago
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

Remove IsConnectionAllowed from JsEngine and from WebRequestThread and made the execution of it asynchronous in FilterEngine, though it is still in a detached thread. # it's a merely small step of the issue, however it will allow to work in parallel on other issues.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -111 lines) Patch
M include/AdblockPlus/JsEngine.h View 3 chunks +0 lines, -21 lines 0 comments Download
M lib/compat.js View 3 chunks +28 lines, -1 line 0 comments Download
M src/FilterEngine.cpp View 3 chunks +42 lines, -20 lines 0 comments Download
M src/JsEngine.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M src/WebRequestJsObject.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M test/FilterEngine.cpp View 6 chunks +48 lines, -39 lines 0 comments Download

Messages

Total messages: 2
sergei
7 months, 2 weeks ago (2017-04-28 14:48:54 UTC) #1
hub
7 months, 2 weeks ago (2017-04-28 15:18:46 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5