Issue 29424786: Issue 5182 - fix IsConnectionAllowed

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29424786: Issue 5182 - fix IsConnectionAllowed (Closed)

Created:
April 28, 2017, 2:42 p.m. by sergei

Modified:
May 2, 2017, 1:20 p.m.

Reviewers:
hub

CC:
Felix Dahlke

Base URL:
https://github.com/adblockplus/libadblockplus.git

Visibility:
Public.

Description

Remove IsConnectionAllowed from JsEngine and from WebRequestThread and made the execution of it asynchronous in FilterEngine, though it is still in a detached thread. # it's a merely small step of the issue, however it will allow to work in parallel on other issues.

Patch Set 1 #

Created: April 28, 2017, 2:42 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+119 lines, -111 lines)			Patch
M	include/AdblockPlus/JsEngine.h	View	3 chunks	+0 lines, -21 lines	0 comments	Download
M	lib/compat.js	View	3 chunks	+28 lines, -1 line	0 comments	Download
M	src/FilterEngine.cpp	View	3 chunks	+42 lines, -20 lines	0 comments	Download
M	src/JsEngine.cpp	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	src/WebRequestJsObject.cpp	View	1 chunk	+1 line, -10 lines	0 comments	Download
M	test/FilterEngine.cpp	View	6 chunks	+48 lines, -39 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages