Issue 29428624: Issue 5180 - stop using of WebRequestPtr in tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29428624: Issue 5180 - stop using of WebRequestPtr in tests (Closed)

Created:
May 3, 2017, 2:07 p.m. by sergei

Modified:
May 8, 2017, 11:09 a.m.

Reviewers:
hub

CC:
Felix Dahlke

Base URL:
https://github.com/adblockplus/libadblockplus.git

Visibility:
Public.

Description

- rename WebRequestPtr to WebRequestSharedPtr - remove usage of JsEngine::GetWebRequest in tests The next step will be introduction of asynchronous WebRequest and WebRequestPtr which is std::unique_ptr to it. # I'm basically using compiler to help refactoring here. If you wonder some of the rest changes are currently available here https://github.com/abby-sergz/libadblockplus/commits/ci-issue5180-p3

Patch Set 1 #

Created: May 3, 2017, 2:07 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -23 lines)			Patch
M	include/AdblockPlus/JsEngine.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	include/AdblockPlus/WebRequest.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/JsEngine.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/BaseJsTest.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/FilterEngine.cpp	View	6 chunks	+6 lines, -7 lines	0 comments	Download
M	test/JsEngine.cpp	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	test/Notification.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/Prefs.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/UpdateCheck.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages