Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29433573: Issue 5181 - Add new hires to eyeo.com/team/ (Closed)

Created:
May 8, 2017, 11:03 a.m. by ire
Modified:
May 9, 2017, 10:03 a.m.
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/web.eyeo.com
Visibility:
Public.

Description

Issue 5181 - Add new hires to eyeo.com/team/

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M includes/globals.tmpl View 1 chunk +8 lines, -0 lines 1 comment Download
A static/images/flags/in.png View Binary file 0 comments Download
A static/images/people/hubert.png View Binary file 0 comments Download
A static/images/people/muzammil.png View Binary file 0 comments Download
A static/images/people/rick.png View Binary file 0 comments Download
A static/images/people/susie.png View Binary file 0 comments Download
A static/images/people/trang.png View Binary file 0 comments Download

Messages

Total messages: 2
ire
May 8, 2017, 11:03 a.m. (2017-05-08 11:03:12 UTC) #1
juliandoucette
May 8, 2017, 11:17 a.m. (2017-05-08 11:17:41 UTC) #2
One NIT below. Otherwise LGTM.

Note: We are still waiting on one image. You can go ahead and push when you are
able + we get that image.

https://codereview.adblockplus.org/29433573/diff/29433574/includes/globals.tmpl
File includes/globals.tmpl (right):

https://codereview.adblockplus.org/29433573/diff/29433574/includes/globals.tm...
includes/globals.tmpl:87: ("2017-04-03", "ca", "rick.png", "Rick Scott",
"Software Tester", " Explorer of the digital and physical worlds.Loves
cross-country skiing, travel, and learning."),
NIT: Missing space after "worlds."

Powered by Google App Engine
This is Rietveld