Issue 5205 - Add Subscription.isDisabled()

libadblockplus-android/jni/JniSubscription.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <AdblockPlus.h>
 #include "Utils.h"
 #include "JniJsValue.h"
 
 static AdblockPlus::Subscription* GetSubscriptionPtr(jlong ptr)
 {
   return JniLongToTypePtr<AdblockPlus::Subscription>(ptr);
 }
 
+static jboolean JNICALL JniIsDisabled(JNIEnv* env, jclass clazz, jlong ptr)
+{
+  try
+  {
+    return GetSubscriptionPtr(ptr)->IsDisabled() ? JNI_TRUE : JNI_FALSE;
+  }
+  CATCH_THROW_AND_RETURN(env, JNI_FALSE)
+}
+
+static void JNICALL JniSetDisabled(JNIEnv* env, jclass clazz, jlong ptr, jboolean disabled)
+{
+  try
+  {
+    return GetSubscriptionPtr(ptr)->SetDisabled((bool)(disabled == JNI_TRUE));

[sergei, 2017/05/22 11:23:39]

I doubt that the cast to bool is required here, normally the type of result of
operator== is bool.

+  }
+  CATCH_AND_THROW(env)
+}
+
 static jboolean JNICALL JniIsListed(JNIEnv* env, jclass clazz, jlong ptr)
 {
   try
   {
     return GetSubscriptionPtr(ptr)->IsListed() ? JNI_TRUE : JNI_FALSE;
   }
   CATCH_THROW_AND_RETURN(env, JNI_FALSE)
 }
 
 static void JNICALL JniAddToList(JNIEnv* env, jclass clazz, jlong ptr)
@@ skipping 48 matching lines @@
 {
   try
   {
     return (GetSubscriptionPtr(ptr)->IsAA() ? JNI_TRUE : JNI_FALSE);
   }
   CATCH_THROW_AND_RETURN(env, JNI_FALSE)
 }
 
 static JNINativeMethod methods[] =
 {
+  { (char*)"isDisabled", (char*)"(J)Z", (void*)JniIsDisabled },
+  { (char*)"setDisabled", (char*)"(JZ)V", (void*)JniSetDisabled },
   { (char*)"isListed", (char*)"(J)Z", (void*)JniIsListed },
   { (char*)"addToList", (char*)"(J)V", (void*)JniAddToList },
   { (char*)"removeFromList", (char*)"(J)V", (void*)JniRemoveFromList },
   { (char*)"updateFilters", (char*)"(J)V", (void*)JniUpdateFilters },
   { (char*)"isUpdating", (char*)"(J)Z", (void*)JniIsUpdating },
   { (char*)"operatorEquals", (char*)"(JJ)Z", (void*)JniOperatorEquals },
   { (char*)"isAcceptableAds", (char*)"(J)Z", (void*)JniIsAcceptableAds },
 };
 
 extern "C" JNIEXPORT void JNICALL Java_org_adblockplus_libadblockplus_Subscription_registerNatives(JNIEnv *env, jclass clazz)
 {
   env->RegisterNatives(clazz, methods, sizeof(methods) / sizeof(methods[0]));
 }