Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29435570: Issue 5205 - Add Subscription.isDisabled() (Closed)

Created:
May 10, 2017, 8:15 a.m. by anton
Modified:
May 26, 2017, 5:59 a.m.
Reviewers:
sergei, diegocarloslima
CC:
Felix Dahlke, René Jeschke, jens
Visibility:
Public.

Description

Issue 5205 - Add Subscription.isDisabled()

Patch Set 1 #

Total comments: 1

Patch Set 2 : removed casting #

Patch Set 3 : removed one more [unnecessary] casting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -2 lines) Patch
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java View 1 chunk +59 lines, -0 lines 0 comments Download
M libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java View 1 chunk +3 lines, -1 line 0 comments Download
M libadblockplus-android/jni/JniFilterEngine.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M libadblockplus-android/jni/JniSubscription.cpp View 1 2 2 chunks +20 lines, -0 lines 0 comments Download
M libadblockplus-android/src/org/adblockplus/libadblockplus/Subscription.java View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7
anton
May 10, 2017, 8:16 a.m. (2017-05-10 08:16:26 UTC) #1
sergei
LGTM https://codereview.adblockplus.org/29435570/diff/29435571/libadblockplus-android/jni/JniSubscription.cpp File libadblockplus-android/jni/JniSubscription.cpp (right): https://codereview.adblockplus.org/29435570/diff/29435571/libadblockplus-android/jni/JniSubscription.cpp#newcode40 libadblockplus-android/jni/JniSubscription.cpp:40: return GetSubscriptionPtr(ptr)->SetDisabled((bool)(disabled == JNI_TRUE)); I doubt that the ...
May 22, 2017, 11:23 a.m. (2017-05-22 11:23:39 UTC) #2
anton
On 2017/05/22 11:23:39, sergei wrote: > LGTM > > https://codereview.adblockplus.org/29435570/diff/29435571/libadblockplus-android/jni/JniSubscription.cpp > File libadblockplus-android/jni/JniSubscription.cpp (right): > ...
May 22, 2017, 11:35 a.m. (2017-05-22 11:35:25 UTC) #3
sergei
LGTM
May 22, 2017, 12:12 p.m. (2017-05-22 12:12:23 UTC) #4
diegocarloslima
On 2017/05/22 12:12:23, sergei wrote: > LGTM LGTM
May 25, 2017, 5:53 p.m. (2017-05-25 17:53:33 UTC) #5
anton
On 2017/05/25 17:53:33, diegocarloslima wrote: > On 2017/05/22 12:12:23, sergei wrote: > > LGTM > ...
May 26, 2017, 5:53 a.m. (2017-05-26 05:53:41 UTC) #6
sergei
May 26, 2017, 5:59 a.m. (2017-05-26 05:59:10 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld