Issue 4586, 5207 - Move the injected wrappers into a separate file

Issue 4586, 5207 - Move the injected wrappers into a separate file

[kzar, 2017-05-12 12:06:24]

Patch Set 1

Mostly I've just moved the code over into a separate file. Other small changes
are commented inline.

https://codereview.adblockplus.org/29437555/diff/29437556/inject.preload.js
File inject.preload.js (right):

https://codereview.adblockplus.org/29437555/diff/29437556/inject.preload.js#n...
inject.preload.js:43: * Shadow root getter wrapper
I improved this comment.

https://codereview.adblockplus.org/29437555/diff/29437556/inject.preload.js#n...
inject.preload.js:50: if ("shadowRoot" in Element.prototype)
I changed this logic, previously we returned if Element.prototype.shadowRoot
didn't exist, but that won't work now that the injected code is all in one large
function.

https://codereview.adblockplus.org/29437555/diff/29437556/inject.preload.js#n...
inject.preload.js:69: /*
I added this comment.

[Sebastian Noack, 2017-05-12 12:12:53]

I really don't think that we should add even more content scripts, as each
content script adds some overhead per document (in addition to its content).

We should rather move forward with the attempts to bundle our content scripts
using the module system. Then you can just add a new module from a separate
file, without increasing the number of content scripts in the generated build.
In fact it will even reduce that number.

[kzar, 2017-05-12 13:00:23]

Patch Set 2 : Avoid adding an extra content script

> I really don't think that we should add even more content scripts,
> as each content script adds some overhead per document (in addition
> to its content).

Fair enough, I've combined inject.preload.js with include.preload.js at build
time now

> We should rather move forward with the attempts to bundle our
> content scripts using the module system. Then you can just add a new
> module from a separate file, without increasing the number of
> content scripts in the generated build.  In fact it will even reduce
> that number.

Agreed that it will be nice when our content scripts use the module system.
Hopefully we can finishing making that happen soon. I'd appreciate some help
with it though, I'd rather not have to make all those changes myself. Maybe we
can find someone to help out with #5079 and #5089 for example?

[Sebastian Noack, 2017-05-16 11:13:36]

LGTM