Issue 29438577: Issue 5248 - Use wildcard to match any subdomains

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29438577: Issue 5248 - Use wildcard to match any subdomains (Closed)

Created:
May 16, 2017, 1:06 a.m. by Manish Jethani

Modified:
May 16, 2017, 1:25 p.m.

Reviewers:
Sebastian Noack, kzar

Base URL:
https://hg.adblockplus.org/abp2blocklist

Visibility:
Public.

Description

Remove the addDomainPrefix function and the tldjs dependency that came with it. Instead, simply add a * character in front of the name. e.g. $domain=example.com should get converted to "if-domain": ["*example.com"]

Patch Set 1 #

Total comments: 1

Created: May 16, 2017, 1:06 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -27 lines)			Patch
M	lib/abp2blocklist.js	View	3 chunks	+3 lines, -19 lines	0 comments	Download
M	package.json	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/abp2blocklist.js	View	2 chunks	+6 lines, -6 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Manish Jethani

Patch Set 1 https://codereview.adblockplus.org/29438577/diff/29438578/test/abp2blocklist.js File test/abp2blocklist.js (left): https://codereview.adblockplus.org/29438577/diff/29438578/test/abp2blocklist.js#oldcode218 test/abp2blocklist.js:218: testRules(test, ["2$domain=third-party"], ["third-party"], This test was ...

May 16, 2017, 1:08 a.m. (2017-05-16 01:08:27 UTC) #2

kzar

LGTM but please file an issue for the change before pushing. It's an important enough ...

May 16, 2017, 8:54 a.m. (2017-05-16 08:54:06 UTC) #4

Manish Jethani

May 16, 2017, 11:29 a.m. (2017-05-16 11:29:05 UTC) #5

On 2017/05/16 08:54:06, kzar wrote:
> LGTM but please file an issue for the change before pushing. It's an important
> enough change to warrant an issue.

Makes sense, I've created #5248 for this now.

Expand All Messages | Collapse All Messages