Issue 4329 - Add $generichide support

Implement support for the generichide option

Let's say we have these filters:

  ##.ad
  blogspot.com##div.textad
  @@||googleblog.blogspot.com^$elemhide
  @@||youtube.com^$generichide

After this change, the program will generate the following rules:

  [
    {
      "trigger": {
        "url-filter": "^https?://",
        "url-filter-is-case-sensitive": true
      },
      "action": {
        "type": "css-display-none",
        "selector": ".ad"
      }
    },
    {
      "trigger": {
        "url-filter": "^https?://([^/]+\\.)?youtube\\.com",
        "url-filter-is-case-sensitive": true
      },
      "action": {
        "type": "ignore-previous-rules"
      }
    },
    {
      "trigger": {
        "url-filter": "^https?://([^/:]*\\.)?blogspot\\.com[/:]",
        "url-filter-is-case-sensitive": true
      },
      "action": {
        "type": "css-display-none",
        "selector": "div.textad"
      }
    },
    {
      "trigger": {
        "url-filter": "^https?://([^/]+\\.)?googleblog\\.blogspot\\.com",
        "url-filter-is-case-sensitive": true
      },
      "action": {
        "type": "ignore-previous-rules"
      }
    }
  ]

[Manish Jethani, 2017-05-17 03:40:17]

Patch Set 1

[Manish Jethani, 2017-05-17 03:48:36]

On 2017/05/17 03:40:17, Manish Jethani wrote:
> Patch Set 1

I should add that I want to do $genericblock separately since it's a completely
different implementation.

[Sebastian Noack, 2017-05-17 06:37:10]

https://codereview.adblockplus.org/29439639/diff/29439640/lib/abp2blocklist.js
File lib/abp2blocklist.js (right):

https://codereview.adblockplus.org/29439639/diff/29439640/lib/abp2blocklist.j...
lib/abp2blocklist.js:422: groupedElemhideFilters.set("^https?://", []);
I'm not sure if it is a good idea, to split up generic and domain-specific
filters based on their output, relying on their url-pattern, hard-coding it in 3
places.

How about splitting up the elemhideFilters array into two, one for generic and
one for domain-specific filters, distinguishing them while they are parsed?

[Manish Jethani, 2017-05-17 14:54:04]

Patch Set 2: Use separate array for generic selectors

https://codereview.adblockplus.org/29439639/diff/29440586/lib/abp2blocklist.js
File lib/abp2blocklist.js (right):

https://codereview.adblockplus.org/29439639/diff/29440586/lib/abp2blocklist.j...
lib/abp2blocklist.js:358: while (selectors.length)
The rest of this function is a cut and paste from below.

[kzar, 2017-05-19 12:12:22]

https://codereview.adblockplus.org/29439639/diff/29440586/lib/abp2blocklist.js
File lib/abp2blocklist.js (right):

https://codereview.adblockplus.org/29439639/diff/29440586/lib/abp2blocklist.j...
lib/abp2blocklist.js:464: addCSSRules(rules, genericSelectors);
Just pass matchDomain of ^https?:// here, then remove the related logic in
addCSSRules?

[Manish Jethani, 2017-05-20 00:16:52]

Patch Set 3: Make matchDomain argument non-optional

[Manish Jethani, 2017-05-20 00:21:43]

Patch Set 4: Fix indentation

[Sebastian Noack, 2017-05-20 06:20:07]

LGTM

[kzar, 2017-05-20 10:21:51]

LGTM