package.json - Issue 29441570: Issue 5257 - Add an eslint target to npm run and run it posttest.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: package.json

Issue 29441570: Issue 5257 - Add an eslint target to npm run and run it posttest. (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Patch Set: Created May 18, 2017, 3:53 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 {	1 {

2 "name": "adblockpluscore",	2 "name": "adblockpluscore",

3 "repository": "https://hg.adblockplus.org/adblockpluscore",	3 "repository": "https://hg.adblockplus.org/adblockpluscore",

4 "license": "GPL-3.0",	4 "license": "GPL-3.0",

5 "dependencies": {},	5 "dependencies": {},

6 "devDependencies": {	6 "devDependencies": {

7 "chrome-remote-interface": "^0.20.0",	7 "chrome-remote-interface": "^0.20.0",

	8 "eslint": "^3.19.0",

	9 "eslint-config-eyeo": "1.0.4",

8 "nodeunit": "0.9.1",	10 "nodeunit": "0.9.1",

9 "sandboxed-module": "2.0.3",	11 "sandboxed-module": "2.0.3",

10 "unzip": "^0.1.11"	12 "unzip": "^0.1.11"

11 },	13 },

12 "scripts": {	14 "scripts": {

13 "test": "node test_runner.js"	15 "eslint": "eslint *.js lib test chrome",
	Wladimir Palant 2017/05/19 15:52:31 IMHO, this will run the global ESLint and not the IMHO, this will run the global ESLint and not the one you added as dependency here. hub 2017/05/19 16:47:31 $ which eslint eslint not found If I echo $PATH f Show quoted text On 2017/05/19 15:52:31, Wladimir Palant wrote: > IMHO, this will run the global ESLint and not the one you added as dependency > here. $ which eslint eslint not found If I echo $PATH from the npm test command, I get the output of `npm bin` ahead of the system directories, like /usr/local/bin. So it will definitely use the one npm just installed locally. Wladimir Palant 2017/05/19 18:12:31 Good to know, definitely saves some complexity her Show quoted text On 2017/05/19 16:47:31, hub wrote: > On 2017/05/19 15:52:31, Wladimir Palant wrote: > > IMHO, this will run the global ESLint and not the one you added as dependency > > here. > > $ which eslint > eslint not found > > If I echo $PATH from the npm test command, I get the output of `npm bin` ahead > of the system directories, like /usr/local/bin. > > So it will definitely use the one npm just installed locally. Good to know, definitely saves some complexity here.
	16 "test": "node test_runner.js",

	17 "posttest": "npm run eslint"

14 }	18 }

15 }	19 }

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »