Issue 29441570: Issue 5257 - Add an eslint target to npm run and run it posttest.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29441570: Issue 5257 - Add an eslint target to npm run and run it posttest. (Closed)

Created:
May 18, 2017, 3:53 p.m. by hub

Modified:
May 19, 2017, 6:25 p.m.

Reviewers:
Felix Dahlke, Wladimir Palant

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Description

Issue 5257 - Add an eslint target to npm run and run it posttest.

Patch Set 1 #

Total comments: 3

Created: May 18, 2017, 3:53 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	package.json	View		1 chunk	+5 lines, -1 line	3 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Wladimir Palant

https://codereview.adblockplus.org/29441570/diff/29441571/package.json File package.json (right): https://codereview.adblockplus.org/29441570/diff/29441571/package.json#newcode15 package.json:15: "eslint": "eslint *.js lib test chrome", IMHO, this will ...

May 19, 2017, 3:52 p.m. (2017-05-19 15:52:31 UTC) #2

hub

May 19, 2017, 4:47 p.m. (2017-05-19 16:47:31 UTC) #3

Wladimir Palant

May 19, 2017, 6:12 p.m. (2017-05-19 18:12:31 UTC) #4

LGTM

This needs to land on master and emscripten branches.

https://codereview.adblockplus.org/29441570/diff/29441571/package.json
File package.json (right):

https://codereview.adblockplus.org/29441570/diff/29441571/package.json#newcode15
package.json:15: "eslint": "eslint *.js lib test chrome",
On 2017/05/19 16:47:31, hub wrote:
> On 2017/05/19 15:52:31, Wladimir Palant wrote:
> > IMHO, this will run the global ESLint and not the one you added as
dependency
> > here.
> 
> $ which eslint
> eslint not found
> 
> If I echo $PATH from the npm test command, I get the output of `npm bin` ahead
> of the system directories, like /usr/local/bin.
> 
> So it will definitely use the one npm just installed locally.

Good to know, definitely saves some complexity here.

Expand All Messages | Collapse All Messages