Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(742)

Issue 29442555: Issue 4934 - Add 'Requirements for Adblock Plus recommended filter lists' page to adblockplus.org (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 4 weeks ago by ire
Modified:
3 months, 1 week ago
Reviewers:
juliandoucette, tamara
CC:
wspee
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Issue 4934 - Add 'Requirements for Adblock Plus recommended filter lists' page to adblockplus.org

Patch Set 1 #

Total comments: 8

Patch Set 2 : Added missing <fix>, Remove space around string brackets, Replace angled quotes #

Total comments: 4

Patch Set 3 : Addressed NITs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
M pages/contribute.html View 1 1 chunk +4 lines, -0 lines 0 comments Download
A pages/filter-lists-requirements.html View 1 2 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 9
ire
6 months, 4 weeks ago (2017-05-19 05:09:49 UTC) #1
juliandoucette
Thanks Ire! :) There are a few minor issues. Note: When I find a NIT ...
6 months, 2 weeks ago (2017-05-30 12:55:03 UTC) #2
ire
I realise you probably didn't see this. I had pushed the new patch a month ...
5 months, 2 weeks ago (2017-06-28 09:59:56 UTC) #3
juliandoucette
LGTM with minor NITs. @Tamara do we want to delay publishing this until we have ...
5 months, 1 week ago (2017-07-03 22:18:23 UTC) #4
tamara
On 2017/07/03 22:18:23, juliandoucette wrote: > LGTM with minor NITs. > > @Tamara do we ...
5 months, 1 week ago (2017-07-04 12:21:12 UTC) #5
juliandoucette
Thanks Tamara :) - Please find follow up questions below. CC Winsley (because this is ...
5 months, 1 week ago (2017-07-04 15:19:25 UTC) #6
tamara
On 2017/07/04 15:19:25, juliandoucette wrote: > Thanks Tamara :) - Please find follow up questions ...
5 months, 1 week ago (2017-07-05 09:24:49 UTC) #7
juliandoucette
On 2017/07/05 09:24:49, tamara wrote: > Regarding the second one, I'd suggest to push that ...
3 months, 2 weeks ago (2017-09-01 12:37:48 UTC) #8
ire
3 months, 1 week ago (2017-09-07 09:48:45 UTC) #9
> @ire you can push this (preferably addressing NITs above beforehand).

Okay

https://codereview.adblockplus.org/29442555/diff/29452271/pages/filter-lists-...
File pages/filter-lists-requirements.html (right):

https://codereview.adblockplus.org/29442555/diff/29452271/pages/filter-lists-...
pages/filter-lists-requirements.html:8: {{filter-lists-requirements-item[Filter
Lists Requirements List Item] Should be open source and have the possibility for
users to report issues/suggest filters}}
On 2017/07/03 22:18:23, juliandoucette wrote:
> NIT: We usually start with "1" instead of nothing.

Done.

https://codereview.adblockplus.org/29442555/diff/29452271/pages/filter-lists-...
pages/filter-lists-requirements.html:12:
{{filter-lists-requirements-item2[Filter Lists Requirements List Item] Must be
unique (does not duplicate another list or filters in another list)}}
On 2017/07/03 22:18:23, juliandoucette wrote:
> NIT: We usually separate numbers by a "-" in string IDs.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5