Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in

Issue 29442555: Issue 4934 - Add 'Requirements for Adblock Plus recommended filter lists' page to adblockplus.org

Can't Edit
Can't Publish+Mail
Start Review
3 months ago by ire
1 month, 2 weeks ago
tamara, juliandoucette
Base URL:


Issue 4934 - Add 'Requirements for Adblock Plus recommended filter lists' page to adblockplus.org

Patch Set 1 #

Total comments: 8

Patch Set 2 : Added missing <fix>, Remove space around string brackets, Replace angled quotes #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
M pages/contribute.html View 1 1 chunk +4 lines, -0 lines 0 comments Download
A pages/filter-lists-requirements.html View 1 1 chunk +49 lines, -0 lines 2 comments Download


Total messages: 7
3 months ago (2017-05-19 05:09:49 UTC) #1
Thanks Ire! :) There are a few minor issues. Note: When I find a NIT ...
2 months, 3 weeks ago (2017-05-30 12:55:03 UTC) #2
I realise you probably didn't see this. I had pushed the new patch a month ...
1 month, 3 weeks ago (2017-06-28 09:59:56 UTC) #3
LGTM with minor NITs. @Tamara do we want to delay publishing this until we have ...
1 month, 2 weeks ago (2017-07-03 22:18:23 UTC) #4
On 2017/07/03 22:18:23, juliandoucette wrote: > LGTM with minor NITs. > > @Tamara do we ...
1 month, 2 weeks ago (2017-07-04 12:21:12 UTC) #5
Thanks Tamara :) - Please find follow up questions below. CC Winsley (because this is ...
1 month, 2 weeks ago (2017-07-04 15:19:25 UTC) #6
1 month, 2 weeks ago (2017-07-05 09:24:49 UTC) #7
On 2017/07/04 15:19:25, juliandoucette wrote:
> Thanks Tamara :) - Please find follow up questions below.
> CC Winsley (because this is relevant to project management)
> On 2017/07/04 12:21:12, tamara wrote:
> > Please note that I didn't know about any of this and I wasn't CC'ed in the
> issue
> > either, so not sure how long until I have the translations.
> I think this implies that we should CC you on every issue that involves a text
> change on a website that is translated. If so, I'm concerned about spamming
> with every minutiae change to such issues. Perhaps we could come up with a
> efficient process? 
> > Considering it's a new page for the website and everything has to be done
> "from
> > scratch", it shouldn't be a problem if we have it live at first in English.
> What about the change to the existing page that links to the new page? If we
> push it, there will be one english paragraph on this page in every language. I
> don't know if we want that or not. What do you think?

Regarding your first question: I completely understand, so I would suggest to
create an issue apart in the Hub where the need for translations for that
specific issue can be brought up. This would help me to keep that lined up in my
ongoing projects so that, as soon as the English can be considered final, I can
then start requesting the translations. Would that help? The Hub is basically a
tool for people to let me know they need translations and for me to have an idea
of what's next in the pipeline, so I can organise my time and different projects
and at least you wouldn't spam me at all.  :)

Regarding the second one, I'd suggest to push that specific change affecting
"abp.org/contribute#filters" as "update_without_changes". It will be then
updated for English while the rest of the languages will still keep and display
the current translations until the new ones are ready for implementation which,
in my opinion, is better than just displaying English. How does that sound?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5