Noissue - Fix some problems Firefox has with our injected code

inject.preload.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 340 matching lines @@
       realSetConfiguration(this, configuration);
       checkConfiguration(this, configuration);
     };
   }
 
   function WrappedRTCPeerConnection(...args)
   {
     if (!(this instanceof WrappedRTCPeerConnection))
       return WrappedRTCPeerConnection();
 
     let configuration = protectConfiguration(args[0]);

[Sebastian Noack, 2017/05/22 12:16:54]

Nit: Perhaps move this definition below where the variable is first used now?

[kzar, 2017/05/22 13:02:04]

Mmh I think it's OK here personally.

+
     // Since the old webkitRTCPeerConnection constructor takes an optional
     // second argument we need to take care to pass that through. Necessary
     // for older versions of Chrome such as 49.
-    let peerconnection = new RealRTCPeerConnection(configuration, args[1]);
+    let constraints = undefined;
+    if (args.length > 1)
+      constraints = args[1];
+
+    let peerconnection = new RealRTCPeerConnection(configuration, constraints);
     checkConfiguration(peerconnection, configuration);
     return peerconnection;
   }
 
   WrappedRTCPeerConnection.prototype = RealRTCPeerConnection.prototype;
 
   let boundWrappedRTCPeerConnection = WrappedRTCPeerConnection.bind();
   copyProperties(RealRTCPeerConnection, boundWrappedRTCPeerConnection,
-                 ["caller", "generateCertificate", "name", "prototype"]);
+                 ["generateCertificate", "name", "prototype"]);
   RealRTCPeerConnection.prototype.constructor = boundWrappedRTCPeerConnection;
 
   if ("RTCPeerConnection" in window)
     window.RTCPeerConnection = boundWrappedRTCPeerConnection;
   if ("webkitRTCPeerConnection" in window)
     window.webkitRTCPeerConnection = boundWrappedRTCPeerConnection;
 }
 
 if (document instanceof HTMLDocument)
 {
   let script = document.createElement("script");
   script.type = "application/javascript";
   script.async = false;
   script.textContent = "(" + injected + ")('" + randomEventName + "');";
   document.documentElement.appendChild(script);
   document.documentElement.removeChild(script);
 }