Noissue - Fix some problems Firefox has with our injected code

Noissue - Fix some problems Firefox has with our injected code

[kzar, 2017-05-22 10:33:30]

Patch Set 1

[kzar, 2017-05-22 10:36:35]

Patch Set 2 : Removed extra newline which was added by mistake

[Wladimir Palant, 2017-05-22 10:55:17]

https://codereview.adblockplus.org/29445594/diff/29445597/inject.preload.js
File inject.preload.js (right):

https://codereview.adblockplus.org/29445594/diff/29445597/inject.preload.js#n...
inject.preload.js:380: ["caller", "generateCertificate", "name", "prototype"]);
So the issue is being caused by trying to copy the caller property. Is it even
necessary to copy it given that it is a generic function property?

[kzar, 2017-05-22 11:25:31]

Patch Set 3 : Don't copy the caller property

I've not been able to properly test WebRTC blocking yet with this change since
that seems to have broken with the changes for #5184.

https://codereview.adblockplus.org/29445594/diff/29445597/inject.preload.js
File inject.preload.js (right):

https://codereview.adblockplus.org/29445594/diff/29445597/inject.preload.js#n...
inject.preload.js:380: ["caller", "generateCertificate", "name", "prototype"]);
On 2017/05/22 10:55:17, Wladimir Palant wrote:
> So the issue is being caused by trying to copy the caller property. Is it even
> necessary to copy it given that it is a generic function property?

Yea, I just checked and "caller" is indeed the problem. Done.

[Wladimir Palant, 2017-05-22 12:03:23]

LGTM

[Sebastian Noack, 2017-05-22 12:16:55]

https://codereview.adblockplus.org/29445594/diff/29445599/inject.preload.js
File inject.preload.js (left):

https://codereview.adblockplus.org/29445594/diff/29445599/inject.preload.js#o...
inject.preload.js:361: let configuration = protectConfiguration(args[0]);
Nit: Perhaps move this definition below where the variable is first used now?

[kzar, 2017-05-22 13:02:04]

https://codereview.adblockplus.org/29445594/diff/29445599/inject.preload.js
File inject.preload.js (left):

https://codereview.adblockplus.org/29445594/diff/29445599/inject.preload.js#o...
inject.preload.js:361: let configuration = protectConfiguration(args[0]);
On 2017/05/22 12:16:54, Sebastian Noack wrote:
> Nit: Perhaps move this definition below where the variable is first used now?

Mmh I think it's OK here personally.

[Sebastian Noack, 2017-05-22 13:03:22]

Fair enough, LGTM.