Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: android-v8-options.gypi

Issue 29451722: Issue 4907 - Update v8 to 5.7.278 in libadblockplus (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: Created May 30, 2017, 3:02 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android-v8-options.gypi
diff --git a/android-v8-options.gypi b/android-v8-options.gypi
new file mode 100644
index 0000000000000000000000000000000000000000..f85c5c6afe618ea72a2abc31a137b50d91be2942
--- /dev/null
+++ b/android-v8-options.gypi
@@ -0,0 +1,19 @@
+{
+ 'variables': {
+ 'want_separate_host_toolset%': 1,
+ 'android_ndk_root': '<!(echo ${ANDROID_NDK_ROOT})',
+ 'clang_dir': '/usr/',
sergei 2017/05/30 15:21:32 "/usr/" is a new magic string here, not sure wheth
Eric 2017/05/30 17:31:40 Since you're already asking for default installati
sergei 2017/05/31 12:47:11 I'm pretty sure that there is no default location
+ 'make_clang_dir': '/usr/',
+ },
+ 'conditions': [[
+ 'v8_target_arch=="arm"', {
+ 'variables': {
+ 'arm_version%': 7,
+ 'arm_fpu%': 'default',
+ 'arm_float_abi%': 'default',
+ 'arm_thumb%': 'default',
+ }
+ }
+ ]],
+ 'includes': ['v8.gypi'],
+}

Powered by Google App Engine
This is Rietveld