Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29453555: Issue 5285 - Fix saving filters on clean Thunderbird or SeaMonkey profiles (Closed)

Created:
June 1, 2017, 9:15 a.m. by Wladimir Palant
Modified:
Aug. 16, 2017, 10:16 a.m.
Reviewers:
Felix Dahlke
Base URL:
https://hg.adblockplus.org/adblockplus
Visibility:
Public.

Description

Issue 5285 - Fix saving filters on clean Thunderbird or SeaMonkey profiles

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M lib/io.js View 1 chunk +12 lines, -1 line 1 comment Download

Messages

Total messages: 3
Wladimir Palant
June 1, 2017, 9:15 a.m. (2017-06-01 09:15:54 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29453555/diff/29453556/lib/io.js File lib/io.js (right): https://codereview.adblockplus.org/29453555/diff/29453556/lib/io.js#newcode104 lib/io.js:104: ensureDirExists(file.parent); For reference, this operation was originally being performed ...
June 1, 2017, 9:16 a.m. (2017-06-01 09:16:41 UTC) #2
Felix Dahlke
June 1, 2017, 10:49 a.m. (2017-06-01 10:49:47 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld