Issue 5287 - Change syntax for element hiding emulation filters and remove simplified element hidin…

lib/filterClasses.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 69 matching lines @@
 /**
  * Cache for known filters, maps string representation to filter objects.
  * @type {Object}
  */
 Filter.knownFilters = Object.create(null);
 
 /**
  * Regular expression that element hiding filters should match
  * @type {RegExp}
  */
-Filter.elemhideRegExp = /^([^/*|@"!]*?)#(@)?(?:([\w-]+|\*)((?:\([\w-]+(?:[$^*]?=[^()"]*)?\))*)|#(.+))$/;
+Filter.elemhideRegExp = /^([^/*|@"!]*?)#([@?])?#(.+)$/;
 /**
  * Regular expression that RegExp filters specified as RegExps should match
  * @type {RegExp}
  */
 Filter.regexpRegExp = /^(@@)?\/.*\/(?:\$~?[\w-]+(?:=[^,\s]+)?(?:,~?[\w-]+(?:=[^,\s]+)?)*)?$/;
 /**
  * Regular expression that options on a RegExp filter should match
  * @type {RegExp}
  */
 Filter.optionsRegExp = /\$(~?[\w-]+(?:=[^,\s]+)?(?:,~?[\w-]+(?:=[^,\s]+)?)*)$/;
 
 /**
  * Creates a filter of correct type from its text representation - does the
  * basic parsing and calls the right constructor then.
  *
  * @param {string} text   as in Filter()
  * @return {Filter}
  */
 Filter.fromText = function(text)
 {
   if (text in Filter.knownFilters)
     return Filter.knownFilters[text];
 
   let ret;
   let match = (text.includes("#") ? Filter.elemhideRegExp.exec(text) : null);
   if (match)
   {
+    let propsMatch;
+    if (!match[2] &&
+        (propsMatch = /\[-abp-properties=(["'])([^"']+)\1\]/.exec(match[3])))
+    {
+      // This is legacy CSS properties syntax, convert to current syntax
+      let prefix = match[3].substr(0, propsMatch.index);
+      let expression = propsMatch[2];
+      let suffix = match[3].substr(propsMatch.index + propsMatch[0].length);
+      return Filter.fromText(`${match[1]}#?#` +
+          `${prefix}:-abp-properties(${expression})${suffix}`);
+    }
+
     ret = ElemHideBase.fromText(
-      text, match[1], !!match[2], match[3], match[4], match[5]
+      text, match[1], match[2], match[3]
     );
   }
   else if (text[0] == "!")
     ret = new CommentFilter(text);
   else
     ret = RegExpFilter.fromText(text);
 
   Filter.knownFilters[ret.text] = ret;
   return ret;
 };
@@ skipping 793 matching lines @@
    * CSS selector for the HTML elements that should be hidden
    * @type {string}
    */
   selector: null
 });
 
 /**
  * Creates an element hiding filter from a pre-parsed text representation
  *
  * @param {string} text         same as in Filter()
- * @param {string} domain
- *   domain part of the text representation (can be empty)
- * @param {boolean} isException exception rule indicator
- * @param {string} tagName      tag name part (can be empty)
- * @param {string} attrRules    attribute matching rules (can be empty)
- * @param {string} selector     raw CSS selector (can be empty)
+ * @param {string?} domain
+ *   domain part of the text representation
+ * @param {string?} type
+*    rule type, either empty or @ (exception) or ? (emulation rule)
+ * @param {string} selector     raw CSS selector
  * @return {ElemHideFilter|ElemHideException|
  *          ElemHideEmulationFilter|InvalidFilter}
  */
-ElemHideBase.fromText = function(text, domain, isException, tagName, attrRules,
-                                 selector)
+ElemHideBase.fromText = function(text, domain, type, selector)
 {
-  if (!selector)
-  {
-    if (tagName == "*")
-      tagName = "";
-
-    let id = null;
-    let additional = "";
-    if (attrRules)
-    {
-      attrRules = attrRules.match(/\([\w-]+(?:[$^*]?=[^()"]*)?\)/g);
-      for (let rule of attrRules)
-      {
-        rule = rule.substr(1, rule.length - 2);
-        let separatorPos = rule.indexOf("=");
-        if (separatorPos > 0)
-        {
-          rule = rule.replace(/=/, '="') + '"';
-          additional += "[" + rule + "]";
-        }
-        else
-        {
-          if (id)
-            return new InvalidFilter(text, "filter_elemhide_duplicate_id");
-
-          id = rule;
-        }
-      }
-    }
-
-    if (id)
-      selector = `${tagName}.${id}${additional},${tagName}#${id}${additional}`;
-    else if (tagName || additional)
-      selector = tagName + additional;
-    else
-      return new InvalidFilter(text, "filter_elemhide_nocriteria");
-  }
-
   // We don't allow ElemHide filters which have any empty domains.
   // Note: The ElemHide.prototype.domainSeparator is duplicated here, if that
   // changes this must be changed too.
   if (domain && /(^|,)~?(,|$)/.test(domain))
     return new InvalidFilter(text, "filter_invalid_domain");
 
-  if (isException)
+  if (type == "@")
     return new ElemHideException(text, domain, selector);
 
-  if (selector.indexOf("[-abp-properties=") != -1)
+  if (type == "?")
   {
     // Element hiding emulation filters are inefficient so we need to make sure
     // that they're only applied if they specify active domains
     if (!/,[^~][^,.]*\.[^,]/.test("," + domain))
       return new InvalidFilter(text, "filter_elemhideemulation_nodomain");
 
+    // The selector should contain at least one :-abp-foo() pseudo-class
+    if (!/:-abp-[\w-]+\(/.test(selector))
+      return new InvalidFilter(text, "filter_elemhideemulation_plainselector");
+
     return new ElemHideEmulationFilter(text, domain, selector);
   }
 
   return new ElemHideFilter(text, domain, selector);
 };
 
 /**
  * Class for element hiding filters
  * @param {string} text see Filter()
  * @param {string} domains  see ElemHideBase()
@@ skipping 39 matching lines @@
  */
 function ElemHideEmulationFilter(text, domains, selector)
 {
   ElemHideBase.call(this, text, domains, selector);
 }
 exports.ElemHideEmulationFilter = ElemHideEmulationFilter;
 
 ElemHideEmulationFilter.prototype = extend(ElemHideBase, {
   type: "elemhideemulation"
 });